Implement esccharopen Dangling backslash lint rule
#181
Conversation
|
Hi @diokey! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
packages/@romejs/js-compiler/transforms/lint/noDanglingBackslashInRegularExpressions.ts
Outdated
Show resolved
Hide resolved
…shInRegularExpressions.ts Co-Authored-By: Sebastian <853712+sebmck@users.noreply.github.com>
Sweet 😊Done Thank you! |
|
Awesome, thank you so much! |
This was initially being caught as
unterminated regular expressionby the tokenizer.I had to update the tokenizer and now it shows
Let me know if that's the right approach or if there's a better way of doing this.
Thanks