This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 667
feat(rome_formatter): predictable order of modifiers #2196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
commented
Mar 2, 2022
Parser conformance results on ubuntu-latestts/babel
ts/microsoft
jsx/babel
js/262
|
ematipico
commented
Mar 2, 2022
MichaReiser
reviewed
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small comments regarding the implementation
However, the bigger question is if this is something the formatter should be opinionated about or not. Prettier isn't.
crates/rome_formatter/src/ts/lists/index_signature_modifier_list.rs
Outdated
Show resolved
Hide resolved
leops
reviewed
Mar 3, 2022
I am not sure if I'm seeing doable, but Prettier is quite opinionated: check their playground |
ematipico
force-pushed
the
feature/format-class-members
branch
2 times, most recently
from
March 3, 2022 11:02
d09d7ac
to
db5a945
Compare
MichaReiser
approved these changes
Mar 3, 2022
ematipico
force-pushed
the
feature/format-class-members
branch
from
March 3, 2022 12:17
db5a945
to
96e77dd
Compare
ematipico
force-pushed
the
feature/format-class-members
branch
from
March 3, 2022 13:57
96e77dd
to
6a99459
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a predictable ordering of modifiers inside the formatter.
Test Plan
Added few test to cover them. Will need to more once
declare
in stable