Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_analyze): noCompareNegZero #2644

Merged
merged 11 commits into from
Jun 9, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jun 2, 2022

Summary

Closes #2647

  1. Finish new analyze rule noCompareNegZero, part of ☂️ First batch of Linter Rules #2642

Test Plan

  1. should pass noCompareNegZero.js under test dir

@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft June 2, 2022 16:51
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 3, 2022 03:11
@IWANABETHATGUY IWANABETHATGUY requested a review from leops June 3, 2022 10:55
@ematipico ematipico changed the title feat: 🎸 (rome_analyze):no compare neg zero feat(rome_analyze): no compare neg zero Jun 3, 2022
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some invalid case that have some more trivias around the code fix?

Some example:

-0 /** commnet **/ === 4
-0
// comment
=== 4
4 === // comment
-0

And see if we are are able to retain the trivia correctly?

@IWANABETHATGUY
Copy link
Contributor Author

Could we add some invalid case that have some more trivias around the code fix?

Some example:

-0 /** commnet **/ === 4
-0
// comment
=== 4
4 === // comment
-0

And see if we are are able to retain the trivia correctly?

Done

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I leave the last approval to @leops

@ematipico ematipico changed the title feat(rome_analyze): no compare neg zero feat(rome_analyze): noCompareNegZero Jun 3, 2022
@IWANABETHATGUY
Copy link
Contributor Author

@leops , Could this pull request be merged?

@leops leops merged commit f795014 into rome:main Jun 9, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the feat/no-compare-neg-zero branch June 16, 2022 03:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noCompareNegZero
3 participants