This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leops
reviewed
Jun 3, 2022
ematipico
reviewed
Jun 3, 2022
ematipico
changed the title
feat: 🎸 (rome_analyze):no compare neg zero
feat(rome_analyze): no compare neg zero
Jun 3, 2022
ematipico
reviewed
Jun 3, 2022
ematipico
reviewed
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some invalid case that have some more trivias around the code fix?
Some example:
-0 /** commnet **/ === 4
-0
// comment
=== 4
4 === // comment
-0
And see if we are are able to retain the trivia correctly?
Done |
ematipico
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I leave the last approval to @leops
leops
approved these changes
Jun 3, 2022
ematipico
changed the title
feat(rome_analyze): no compare neg zero
feat(rome_analyze): noCompareNegZero
Jun 3, 2022
@leops , Could this pull request be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2647
noCompareNegZero
, part of ☂️ First batch of Linter Rules #2642Test Plan
noCompareNegZero.js
under test dir