This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_analyze): noSparseArray #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
commented
Jun 3, 2022
|
@IWANABETHATGUY could you please comment on the original PR saying that you implement this rule and create an issue to track it? I updated the umbrella issue with some instructions so there won't be conflicts with other contributors |
|
Got it. |
IWANABETHATGUY
changed the title
ematipico
changed the title
leops
reviewed
Jun 9, 2022
…s into feat/no-sparse-array
|
@leops , I guess this pull request is ready to review too. |
|
Sorry for bothering you , but conflict resolve is pretty annoying. |
leops
approved these changes
Jun 10, 2022
ematipico
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Looks good. You need to run the codegen command: https://github.com/rome/tools/blob/main/CONTRIBUTING.md#cargo-codegen-analyzer
|
@ematipico , same here, I have been addressed all the issues. |
leops
suggested changes
Jun 13, 2022
leops
approved these changes
Jun 13, 2022
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Jun 15, 2022
* chore: 🤖 checkpoint * test: 💍 add code action * test: 💍 add more test case * test: 💍 add more test case * test: 💍 tweak test case * fix: 🐛 test * test: 💍 fix test case * test: 💍 update test case * chore: 🤖 remove test main * fix: 🐛 tweak text * chore: 🤖 shapshot * fix: 🐛 compile error * fix: 🐛 address issue * fix: 🐛 address cr issue * fix: 🐛 address cr * fix: 🐛 snapshot Co-authored-by: l3ops <leops@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
no_sparse_arrayanalyze rule, part of ☂️ First batch of Linter Rules #2642Test Plan
pass the test case