This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_analyze): noUnusedTemplateLiteral #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
changed the title
ematipico
approved these changes
Jun 6, 2022
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…HATGUY/tools into feat/no_unused_template_literal
ematipico
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Looks good to me. You need to run the codegen command: https://github.com/rome/tools/blob/main/CONTRIBUTING.md#cargo-codegen-analyzer
|
Done |
compile error
|
@ematipico , This pull request has been approved three days long, could it be merged? |
|
I leave the merging to @leops because he's still working on the internal infrastructure. |
leops
suggested changes
Jun 13, 2022
crates/rome_analyze/src/analyzers/no_unused_template_literal.rs
Outdated
Show resolved
Hide resolved
…HATGUY/tools into feat/no_unused_template_literal
leops
approved these changes
Jun 13, 2022
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Jun 15, 2022
* feat: 🎸 no_unsed_template_literal * test: 💍 pass test case * test: 💍 add more testcase * Update crates/rome_analyze/src/analyzers/no_unused_template_literal.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> * Update crates/rome_analyze/src/analyzers/no_unused_template_literal.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> * fix: 🐛 address cr * chore: 🤖 fix compile error * style: 💄 fmt * chore: 🤖 what * chore: 🤖 merge main * chore: 🤖 merge main Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
noUnusedTemplateLiteralTest Plan
noUnusedTemplateLiteral.js