Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_analyze): useBlockStatements #2658

Merged
merged 16 commits into from
Jun 21, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jun 5, 2022

Summary

  1. add rome_analyze rule useBlockStatements
  2. Resolved 📎useBlockStatements #2659

Test Plan

  1. pass snapshot testing

@ematipico
Copy link
Contributor

@IWANABETHATGUY could you please add comment every time you decide to tackle an issue?

Please read the instructions in the umbrella issue #2642

This will help us to avoid duplicate PRs among contributors (which counts us core team).

@IWANABETHATGUY
Copy link
Contributor Author

@IWANABETHATGUY could you please add comment every time you decide to tackle an issue?

Please read the instructions in the umbrella issue #2642

This will help us to avoid duplicate PRs among contributors (which counts us core team).

Done.

@ematipico
Copy link
Contributor

@IWANABETHATGUY could you please add comment every time you decide to tackle an issue?

Please read the instructions in the umbrella issue #2642

This will help us to avoid duplicate PRs among contributors (which counts us core team).

Done.

To be more specific, you would need to leave a comment in this issue #2642 (the umbrella issue)

@leops leops mentioned this pull request Jun 10, 2022
21 tasks
@ematipico ematipico changed the title feat/(rome_analyze): useBlockStatements feat(rome_analyze): useBlockStatements Jun 10, 2022
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 17, 2022 16:53
@IWANABETHATGUY
Copy link
Contributor Author

@leops , @ematipico , would you mind helping with reviewing the code?

@ematipico ematipico requested a review from leops June 20, 2022 15:14
@ematipico ematipico merged commit 175cbb7 into rome:main Jun 21, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the feat/use-block-statements branch June 21, 2022 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎useBlockStatements
3 participants