test(rome_js_formatter): update prettier tests

[denbezrukov]

Summary

Update prettier tests and prettier version for a playground.

• https://github.com/rome/tools/blob/main/crates/rome_js_formatter/tests/specs/prettier/README.md

Prettier after 2.6.0 release treats comment different.

Input

f4 = // Comment 
() => {};

2.6.0 Playground

f4 = // Comment
  () => {};

Rome playground

f4 = () => {}; // Comment

Test Plan

???

[MichaReiser]

Nice. What do you think of changing prettier's trailingComma option to always to match Rome's default behaviour? Would that be possible or is this hard to achieve because of how we run the tests today?

[denbezrukov]

Nice. What do you think of changing prettier's trailingComma option to always to match Rome's default behaviour? Would that be possible or is this hard to achieve because of how we run the tests today?

What is Rome's default behaviour for trailingComma? Is it all?

• https://prettier.io/docs/en/options.html#trailing-commas

Hmm,
Do you mean it's better to translate prettier's snapshots with different options before extracting them?

[ematipico]

What is Rome's default behaviour for trailingComma? Is it all?

Yes, by default Rome always adds a trailing comma

Hmm,
Do you mean it's better to translate prettier's snapshots with different options before extracting them?

Yes. Rome and Prettier have different defaults

[MichaReiser]

Hmm,
Do you mean it's better to translate prettier's snapshots with different options before extracting them?

That would be awesome if it's doable with a reasonable effort. I'm not familiar with how the test extraction works so I'm unable to assess the effort and maybe it's even best to tackle this in a separate PR.

[denbezrukov]

That would be awesome if it's doable with a reasonable effort. I'm not familiar with how the test extraction works so I'm unable to assess the effort and maybe it's even best to tackle this in a separate PR.

Interesting, I think that we can do it. We can try to re-run prettier with options before saving snapshot.

[denbezrukov]

@MichaReiser @ematipico
Additional format with prettier before snapshot saving.

925f6a9 - file changes
a0291f3 - snapshot changes

[MichaReiser]

Looks good to me. I didn't review all snapshot changes but I love it that prettier's snapshots now matches Rome's options.

[MichaReiser]

This is awesome. Something we wanted for a long time but no-one ever looked into it. Thank you so much for updating the tests with matching options.