This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): dbg_write API compatibility with write
#2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
commented
Jun 14, 2022
| @@ -433,6 +433,18 @@ pub trait BufferExtensions: Buffer + Sized { | |||
| { | |||
| Inspect::new(self, inspector) | |||
| } | |||
|
|
|||
| /// Writes a sequence of elements into this buffer. | |||
There was a problem hiding this comment.
Yeah, I sneaked that into this PR. This allows writing a sequence of elements without going over buffer.into_element
MichaReiser
force-pushed
the
fix/write-dbg-mut-buffer
branch
from
353ad49
to
6e1147f
Compare
Deploying with
|
| Latest commit: |
f51e55e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdfdfa9b.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-write-dbg-mut-buffer.tools-8rn.pages.dev |
This PR ensures that the `buffer` argument of `dbg_write!` is compatible with the `buffer` argument of `write!` so that the two can be swapped without any changes to the debugged code. The current implementation hasn't been compatible because the `dbg_write!` macro called into `Inspect::new` that expected a `&mut Buffer` which requires the use of `&mut buffer` if an implementation uses a local `Buffer` variable. This PR changes the macro implementation to use `Buffer.inspect` instead that works for any mutable `Buffer`.
MichaReiser
force-pushed
the
fix/write-dbg-mut-buffer
branch
from
6e1147f
to
f51e55e
Compare
ematipico
approved these changes
Jun 14, 2022
leops
approved these changes
Jun 14, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the
bufferargument ofdbg_write!is compatible with thebufferargument ofwrite!so that the two can be swapped without any changes to the debugged code.The current implementation hasn't been compatible because the
dbg_write!macro called intoInspect::newthat expected a&mut Bufferwhich requires the use of&mut bufferif an implementation uses a localBuffervariable.This PR changes the macro implementation to use
Buffer.inspectinstead that works for any mutableBuffer.Test Plan
I changed the
dbg_writemacro test to pass inbufferwithout&mut.