You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR brings Rome's class formatting closer to Prettier's.
## Test
Manually verified the output of each updated snapshot test with prettier's to make sure they match (except for comment positioning)
It looks good to me! Would you mind adding new test cases to cover in our test suite?
I'm not sure how much value they bring because the prettier test suite already covers them well. I would literally end up copy pasting the test cases from prettier to ours and I believe that this only ends up generating noise.
It looks good to me! Would you mind adding new test cases to cover in our test suite?
I'm not sure how much value they bring because the prettier test suite already covers them well. I would literally end up copy pasting the test cases from prettier to ours and I believe that this only ends up generating noise.
Simply because one day in the future we might want to rely on our test suite because we don't want to follow prettier anymore. And if that happens (it will for many things), having our test suites is more reliable, and we cover us from possible regressions.
It looks good to me! Would you mind adding new test cases to cover in our test suite?
I'm not sure how much value they bring because the prettier test suite already covers them well. I would literally end up copy pasting the test cases from prettier to ours and I believe that this only ends up generating noise.
Simply because one day in the future we might want to rely on our test suite because we don't want to follow prettier anymore. And if that happens (it will for many things), having our test suites is more reliable, and we cover us from possible regressions.
I can see how we ultimately want to have our own tests but I would I would recommend to move all Prettier tests into our test suite if that moment comes or we risk to loose test coverage.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MichaReiser
force-pushed
the
feat/format-class
branch
from
This PR brings Rome's class formatting closer to Prettier's.
Test
Manually verified the output of each updated snapshot test with prettier's to make sure they match (except for comment positioning)
Before:
File Based Average Prettier Similarity: 74.79%
Line Based Average Prettier Similarity: 69.89%
After:
File Based Average Prettier Similarity: 74.99%
Line Based Average Prettier Similarity: 70.40%
Summary