This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): variable declarator formatting #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
That's great! Could you add the compatibility numbers?
You'd need to run
REPORT_PRETTIER=1 cargo testAnd copy the lines at the bottom of the file report.md.
It will be something like
**File Based Average Prettier Similarity**: 75.24%
**Line Based Average Prettier Similarity**: 70.33%
On this PR and main (both updated) so we can see how much we got closer!
|
current: main: |
MichaReiser
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially implements #2423
Prev PR with discussion: #2737
current:
File Based Average Prettier Similarity: 76.28%
Line Based Average Prettier Similarity: 70.99%
main:
File Based Average Prettier Similarity: 75.24%
Line Based Average Prettier Similarity: 70.33%
This PR adds
OnlyLeftlayout to the list of layouts. This layout is hit, usually, when variable declarator doesn't have initializer.should_break_left_hand_sidewhen variable declarationhas_complex_type_annotation. Prettier hasComplexTypeAnnotation.should_not_indent_if_parent_indents. Don't indent ifgreat_parentisJS_VARIABLE_DECLARATOR.Test Plan
Add new tests specs