This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_formatter): Remove unnecessary groups from format_separated
#2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparated` `format_separated` used to group all elements by default. This is often undesired and also comes with a performance cost (printer needs to test if the elements fit). This PR changes the default of `format_separated` so that it doesn't group the elements except if enabled explicitly using `nodes_grouped`. This PR further fixes the formatting of named import specifiers to more closely match Prettier's foramtting.
MichaReiser
force-pushed
the
refactor/separated-nodes-grouped
branch
from
f8074de
to
4b4a9bb
Compare
Deploying with
|
| Latest commit: |
4b4a9bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e61831a2.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-separated-nodes-gro.tools-8rn.pages.dev |
ematipico
approved these changes
Jun 23, 2022
|
!bench_formatter |
Formatter Benchmark Results |
Formatter Benchmark Results |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_separatedused to group all elements by default. This is often undesired and also comes with a performance cost (printer needs to test if the elements fit).This PR changes the default of
format_separatedso that it doesn't group the elements except if enabled explicitly usingnodes_grouped.This PR further fixes the formatting of named import specifiers to more closely match Prettier's formatting.
Test Plan
cargo testand I compared the snapshot changes with Prettier to make sure they match.