This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feature(rome_js_formatter): TS Interface formatting #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
feature/interface-formatting
branch
from
575739a
to
b1f6144
Compare
|
@ematipico I'll leave it to you to decide if you want to ignore the problematic lines and add it to the Tasks section of #2768 or leave the PR open |
Deploying with
|
| Latest commit: |
5cb2757
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fca09f7.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-interface-formatting.tools-8rn.pages.dev |
|
I resolved the instable comment formatting by manually handling comments inside of the interface formatter. This isn't ideal but lets us move forward |
ematipico
approved these changes
Jun 24, 2022
Comment on lines
+73
to
+74
| (_, Some(extends_clause)) => extends_clause.syntax(), | ||
| (Some(type_parameters), None) => type_parameters.syntax(), |
There was a problem hiding this comment.
nit: Both None of both _? Just to be consistent
There was a problem hiding this comment.
In the first case it can be Some(_) | None, that's why I used _. In the second case it can only ever be None (guaranteed by the match above)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the formatting of TS interface declarations.
Test Plan
Verified the updated snapshots manually and compared them with prettier
File Based Average Prettier Similarity: 76.01% -> 76.26%
Line Based Average Prettier Similarity: 70.85% -> 71.23%