This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): indentation before arrow fn is JSX #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4003b83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10115b0f.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-indentation-before-arrow.tools-8rn.pages.dev |
ematipico
force-pushed
the
fix/indentation-before-arrow-fn
branch
from
fa932ca
to
4003b83
Compare
leops
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR pushes two changes:
This gives us a sense of how the JSX formatting is, and I can see that, apart some some differences, we can say that is stable enough!
Test Plan
Added a new test for effects and update the current snapshots. Checked that the result is what we want
PR
File Based Average Prettier Similarity: 76.50%
Line Based Average Prettier Similarity: 72.00%
mainFile Based Average Prettier Similarity: 76.47%
Line Based Average Prettier Similarity: 71.99%