This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(vscode): enable formatting for JSX and TSX files #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4373fae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2abe2692.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-enable-jsx-vscode.tools-8rn.pages.dev |
ematipico
changed the title
ematipico
changed the title
leops
reviewed
Jun 29, 2022
editors/vscode/package.json
Outdated
| @@ -3,11 +3,13 @@ | |||
| "publisher": "rome", | |||
| "displayName": "Rome", | |||
| "description": "Rome LSP VS Code Extension", | |||
| "version": "0.8.0", | |||
| "version": "0.9.0", | |||
There was a problem hiding this comment.
I think this change shouldn't have been committed since bumping the version number will trigger a release workflow, and the 0.9.0 version number is reserved for pre-releases of the extension
There was a problem hiding this comment.
Shoot! Good catch! Yes, it should NOT be here
leops
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables formatting of
jsxandtsxfiles inside the VS Code extension.Test Plan
I tried locally by installing it on my VS Code. The user has to manually enable Rome as default formatter for these files