Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noUnnecessaryContinue #2796

Merged
merged 12 commits into from
Jul 1, 2022
Merged

feat(rome_js_analyze): noUnnecessaryContinue #2796

merged 12 commits into from
Jul 1, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jun 29, 2022 •
edited

Summary

  1. Resolved noUnnecessaryContinue #2746

Test Plan

  1. cargo test

@IWANABETHATGUY IWANABETHATGUY changed the title Feat/no unnecessary continue feat(rome_js_analyze): noUnnecessaryContinue Jun 29, 2022
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 29, 2022 15:54
leops
leops reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I can't help but wonder if this would be easier to implement by running the checks on the control flow graph instead of the syntax tree, but that's not ready at the moment

crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs Outdated Show resolved Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs Outdated Show resolved Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs Outdated Show resolved Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs Outdated Show resolved Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs Outdated Show resolved Hide resolved
@IWANABETHATGUY
Copy link
Contributor Author

I would like to have a try after rome_controlflow landed.

@IWANABETHATGUY
Copy link
Contributor Author

I have been addressed all issues, would you mind reviewing again?

@ematipico ematipico merged commit 9943a3d into rome:main Jul 1, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the feat/no-unnecessary-continue branch July 1, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

noUnnecessaryContinue
3 participants
@IWANABETHATGUY @ematipico @leops