This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): breaking logic for member chains #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feature/member-chain-best-fitting
branch
from
4fc49f1
to
1d167d9
Compare
Deploying with
|
| Latest commit: |
1d167d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://99250226.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-member-chain-best-fi.tools-8rn.pages.dev |
leops
approved these changes
Jul 1, 2022
| @@ -90,7 +93,50 @@ impl Groups { | |||
| let call_expressions_are_not_simple = | |||
| calls_count > 2 && self.call_expressions_are_not_simple()?; | |||
|
|
|||
| Ok(call_expressions_are_not_simple) | |||
| // TODO: add here will_break logic | |||
There was a problem hiding this comment.
What exactly is this todo here about ?
There was a problem hiding this comment.
A reminder for me to add more logic here. The logic should decide to break the group if some member of the chain will break. I decided to have a TODO here because it's not a small implementation and it requires its own PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds again a check on the breaking logic of the member chain. The check is around comments. I also fixed the previous logic, where the check for certain comments was incorrectly done.
Test Plan
cargo testand checked that snapshots are correctly updatedPR
File Based Average Prettier Similarity: 77.33%
Line Based Average Prettier Similarity: 72.59%
mainFile Based Average Prettier Similarity: 77.25%
Line Based Average Prettier Similarity: 72.45%