Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

ci: add documentation check on CI #2806

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jul 1, 2022

Summary

This PR does two things:

  • adds the documentation check on the pull_request workflow and main workflow
  • fixes warnings in the documentation

For now I added rome_formatter, rome_analyeze and rome_control_flow to the list of crates we want to document. Mostly because they are generic. Are there any other crates are worth documenting and push on github pages?

Test Plan

This PR should fail if there are warnings in the documentation.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 1, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eaa124c
Status: ✅  Deploy successful!
Preview URL: https://ad461963.tools-8rn.pages.dev
Branch Preview URL: https://feature-documentation-check.tools-8rn.pages.dev

View logs

@ematipico ematipico temporarily deployed to aws July 1, 2022 13:39 Inactive
@ematipico ematipico marked this pull request as ready for review July 1, 2022 13:39
@ematipico ematipico force-pushed the feature/documentation-check branch from 9761f9b to 0c20a0d Compare July 1, 2022 13:41
@ematipico ematipico temporarily deployed to aws July 1, 2022 13:41 Inactive
@ematipico ematipico requested a review from a team July 1, 2022 13:42
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

@leops
Copy link
Contributor

leops commented Jul 1, 2022

It might be useful to add rome_diagnostics to the crates documented on the website. Having rome_rowan and the rome_*_syntax / rome_*_factory could also make sense, to provide an easily searchable documentation for the Syntax API. Finally other library crates like rome_service, rome_console or rome_fs could be included, although these are a bit more "internal facing"

@ematipico ematipico temporarily deployed to aws July 1, 2022 15:26 Inactive
@@ -30,7 +30,7 @@
//!
//! # Implementations
//!
//! Currently the [Workspace] trait is implemented for a single [server::WorkspaceServer]
//! Currently the [Workspace] trait is implemented for a single `WorkspaceServer`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This item was private, so I removed the link to not break its visibility. We can revisit it later

@@ -76,7 +78,7 @@ impl AnalysisFilter<'_> {
}

/// Utility type to be used as a default value for the `B` generic type on
/// [analyze] when the provided callback never breaks
/// `analyze` when the provided callback never breaks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analyze is function that lives in rome_js_analyze, so a link is not possible at the moment

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45878 45878 0
Passed 44938 44938 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 388 388 0
Failed 5558 5558 0
Panics 0 0 0
Coverage 6.53% 6.53% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12393 12393 0
Failed 3864 3864 0
Panics 0 0 0
Coverage 76.23% 76.23% 0.00%

@xunilrj
Copy link
Contributor

xunilrj commented Jul 1, 2022

Do you think makes sense to upload the documentation together with the playground?

@ematipico
Copy link
Contributor Author

Do you think makes sense to upload the documentation together with the playground?

Yes, although we should figure out first where to upload the documentation. The playground uses a mix of s3 and cloudflare. And unfortunately AWS is not correctly set up for everyone yet.

@ematipico ematipico temporarily deployed to aws July 4, 2022 10:15 Inactive
@ematipico ematipico merged commit d9e82e1 into main Jul 4, 2022
@ematipico ematipico deleted the feature/documentation-check branch July 4, 2022 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants