fix(rome_js_parser): Adding syntax error for new A?.b() #3118

IWANABETHATGUY · 2022-08-27T10:34:21Z

Summary

Adding syntax error for new A?.b()
Fixes 🐛 Missing syntax error for new A?.b() #3115

Test Plan

Ci should pass
Checking the newly added snapshot

IWANABETHATGUY · 2022-08-27T10:37:02Z

crates/rome_js_parser/src/syntax/expr.rs

    if p.at(T!['(']) {
        parse_call_arguments(p).unwrap();
+    } else if p.at(T![?.]) && is_identifier_expression {
+        let error = p
+            .err_builder("Invalid optional chain from new expression.")


Do we need to add detailed error descriptions like Typescript?That would introduce extra overhead, I think Invalid optional chain from new expression. would be enough.

MichaReiser · 2022-08-27T10:41:04Z

This seems to be a new error introduced with TypeScript 4.8.

Please add a few more complicated tests where the optional chain isn't the first member

new A.b?.c()
new (A.b)?.c()
new (A.b?.()).c()
new A.b?.()()

I'm not sure that it will be feasible to catch all those inside of the parser or if it would be better to implement them as a rule.

crates/rome_js_parser/test_data/inline/err/invalid_optional_chain_from_new_expressions.rast

IWANABETHATGUY · 2022-08-27T10:59:24Z

Typescript behavior https://www.typescriptlang.org/play?ts=4.8.0-beta#code/HYUw7gBAggdARgfhgYwBQEoBQpKtndJNLHCPeJDdFDbcaCmDWoA

IWANABETHATGUY · 2022-08-27T11:01:27Z

The testing has been updated.

IWANABETHATGUY · 2022-08-27T14:01:08Z

!bench_parser

github-actions · 2022-08-27T14:17:12Z

Parser Benchmark Results

group                                 main                                   pr
-----                                 ----                                   --
parser/checker.ts                     1.00    151.7±3.62ms    17.1 MB/sec    1.03    156.2±4.05ms    16.6 MB/sec
parser/compiler.js                    1.00    100.0±1.52ms    10.5 MB/sec    1.02    101.9±1.49ms    10.3 MB/sec
parser/d3.min.js                      1.00     55.4±0.73ms     4.7 MB/sec    1.00     55.6±0.47ms     4.7 MB/sec
parser/dojo.js                        1.00      4.7±0.01ms    14.6 MB/sec    1.01      4.7±0.01ms    14.5 MB/sec
parser/ios.d.ts                       1.00    130.3±2.95ms    14.3 MB/sec    1.02    133.5±2.83ms    14.0 MB/sec
parser/jquery.min.js                  1.01     14.4±0.64ms     5.7 MB/sec    1.00     14.2±0.13ms     5.8 MB/sec
parser/math.js                        1.00    106.8±2.29ms     6.1 MB/sec    1.01    107.4±2.01ms     6.0 MB/sec
parser/parser.ts                      1.00      3.3±0.00ms    14.8 MB/sec    1.01      3.3±0.01ms    14.7 MB/sec
parser/pixi.min.js                    1.00     64.2±1.48ms     6.8 MB/sec    1.03     66.1±0.76ms     6.6 MB/sec
parser/react-dom.production.min.js    1.00     19.6±0.24ms     5.9 MB/sec    1.02     20.0±0.20ms     5.8 MB/sec
parser/react.production.min.js        1.00   1042.1±1.01µs     5.9 MB/sec    1.01   1052.7±0.72µs     5.8 MB/sec
parser/router.ts                      1.00      2.8±0.06ms    21.7 MB/sec    1.00      2.8±0.00ms    21.6 MB/sec
parser/tex-chtml-full.js              1.00    143.0±2.42ms     6.4 MB/sec    1.00    143.5±1.59ms     6.4 MB/sec
parser/three.min.js                   1.00     75.0±1.28ms     7.8 MB/sec    1.01     76.0±0.79ms     7.7 MB/sec
parser/typescript.js                  1.00   628.0±16.17ms    15.1 MB/sec    1.00   630.0±14.47ms    15.1 MB/sec
parser/vue.global.prod.js             1.00     24.5±0.26ms     4.9 MB/sec    1.01     24.8±0.24ms     4.8 MB/sec

IWANABETHATGUY · 2022-08-28T05:17:39Z

crates/rome_js_parser/src/syntax/typescript/types.rs

@@ -1246,7 +1246,7 @@ pub(crate) fn parse_ts_type_arguments_in_expression(p: &mut Parser) -> ParsedSyn
        p.re_lex(ReLexContext::TypeArgumentLessThan);
        let arguments = parse_ts_type_arguments_impl(p, false);

-        if p.last() == Some(T![>]) && matches!(p.cur(), T!['('] | BACKTICK) {
+        if p.last() == Some(T![>]) && matches!(p.cur(), T!['('] | BACKTICK | T![?.]) {


https://www.typescriptlang.org/play?ts=4.8.0-beta#code/FAEwpgxgNghgTmABAMwK4DsIBcCWB7dRLMAZywB4AVAPgAoBKALkRnQE8BuD4YYs8snBzoA5tQD8AOj5YOQA, parse_ts_type_arguments_in_expression follow a ?. token is valid in typescript

Would you mind adding a new test case showing when this is valid?

This is related to instantiation expressions that our parser currently doesn't support. I recommend tackling this in a separate PR as it is more involved:

microsoft/TypeScript@e6808c4

ematipico · 2022-09-05T08:27:20Z

Adding 0.10.0 milestone to only signal to not merge this PR before 0.9.0 release

github-actions · 2022-09-19T12:04:30Z

This PR is stale because it has been open 14 days with no activity.

netlify · 2022-09-20T12:56:29Z

✅ Deploy Preview for docs-rometools ready!

Name	Link
🔨 Latest commit	`7278b0b`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/632b2a336a6bde0008ca1ed1
😎 Deploy Preview	https://deploy-preview-3118--docs-rometools.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

IWANABETHATGUY · 2022-09-20T13:15:59Z

@MichaReiser, Since the main logic of InstantiationExpression have been finished, we could push forward this pull request,

IWANABETHATGUY · 2022-09-20T13:16:52Z

You could refer to this patch pr of https://github.com/microsoft/TypeScript/pull/48656/files, pretty much just porting.

IWANABETHATGUY · 2022-09-20T13:18:28Z

The rest of two patch pr of instantiationExpression only modified https://github.com/microsoft/TypeScript/pull/48659/files#diff-12a6724be007eb1a19d80018c7a63bbc73525ca793a9b3e5da49a4e86bbf457cL5732-L5765 canFollowTypeArgumentsInExpression, we could skip now.

IWANABETHATGUY · 2022-09-20T13:19:43Z

Why I want to push forward because this pr has been marked as stale, maybe closed a few days later.

IWANABETHATGUY · 2022-09-20T13:37:34Z

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts

@@ -147,6 +147,6 @@ if ((this ?? {}).#bar) { foo.bar; }

 (undefined && this ?? {}).#bar;
 (((typeof this) as string) || {}).#bar;
-(new foo || {}).bar;
+// (new foo || {}).bar;


Why I disabled this test case , please refer to #3257

If I don't do this, the CI will crash. https://github.com/rome/tools/actions/runs/3090461304/jobs/4999289555

You could add // disabled because of https://github.com/rome/tools/issues/3257 to the comment, so we know the reason :)

IWANABETHATGUY · 2022-09-20T14:34:50Z

!bench_parser

github-actions · 2022-09-20T14:51:30Z

Parser Benchmark Results

group                                 main                                   pr
-----                                 ----                                   --
parser/checker.ts                     1.00   150.4±10.67ms    17.3 MB/sec    1.02   152.7±11.27ms    17.0 MB/sec
parser/compiler.js                    1.09     95.7±5.84ms    10.9 MB/sec    1.00     87.8±3.98ms    11.9 MB/sec
parser/d3.min.js                      1.00     52.1±2.96ms     5.0 MB/sec    1.05     54.9±3.26ms     4.8 MB/sec
parser/dojo.js                        1.05      4.9±0.19ms    13.9 MB/sec    1.00      4.7±0.22ms    14.6 MB/sec
parser/ios.d.ts                       1.02    123.9±6.48ms    15.1 MB/sec    1.00    121.9±7.13ms    15.3 MB/sec
parser/jquery.min.js                  1.02     14.3±0.57ms     5.8 MB/sec    1.00     14.0±0.53ms     5.9 MB/sec
parser/math.js                        1.00    101.4±5.60ms     6.4 MB/sec    1.01    102.5±6.09ms     6.3 MB/sec
parser/parser.ts                      1.00      3.4±0.15ms    14.4 MB/sec    1.01      3.4±0.19ms    14.2 MB/sec
parser/pixi.min.js                    1.00     60.9±2.72ms     7.2 MB/sec    1.03     62.7±4.16ms     7.0 MB/sec
parser/react-dom.production.min.js    1.06     19.9±0.77ms     5.8 MB/sec    1.00     18.7±0.55ms     6.1 MB/sec
parser/react.production.min.js        1.04  1098.6±50.66µs     5.6 MB/sec    1.00  1056.3±62.72µs     5.8 MB/sec
parser/router.ts                      1.01      2.9±0.17ms    20.9 MB/sec    1.00      2.9±0.15ms    21.1 MB/sec
parser/tex-chtml-full.js              1.00    134.5±6.38ms     6.8 MB/sec    1.02    137.5±8.97ms     6.6 MB/sec
parser/three.min.js                   1.00     68.6±3.34ms     8.6 MB/sec    1.00     68.3±3.74ms     8.6 MB/sec
parser/vue.global.prod.js             1.04     24.2±0.86ms     5.0 MB/sec    1.00     23.2±1.04ms     5.2 MB/sec

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts.snap

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts

crates/rome_js_parser/src/syntax/expr.rs

IWANABETHATGUY · 2022-09-21T14:49:24Z

crates/rome_js_parser/src/syntax/expr.rs

@@ -768,6 +768,16 @@ fn parse_new_expr(p: &mut Parser, context: ExpressionContext) -> ParsedSyntax {
        .or_add_diagnostic(p, expected_expression)
        .map(|expr| parse_member_expression_rest(p, expr, context, false, &mut false))
    {
+        if p.at(T![?.]) {


Move the error checking here because I don't want to clone the lhs.text(p). If put this branch here, https://github.com/rome/tools/pull/3118/files#diff-1ca6d1ff770e933910c550807255d1bf03cdebbf60bf469579b528c0c28c1537R797, you can't return a &str of lhs.text(p) because lhs is moved via lhs.undo_completion(p)

IWANABETHATGUY requested review from MichaReiser and xunilrj as code owners August 27, 2022 10:34

IWANABETHATGUY commented Aug 27, 2022

View reviewed changes

MichaReiser reviewed Aug 27, 2022

View reviewed changes

crates/rome_js_parser/test_data/inline/err/invalid_optional_chain_from_new_expressions.rast Outdated Show resolved Hide resolved

IWANABETHATGUY requested review from MichaReiser and removed request for xunilrj August 28, 2022 05:10

IWANABETHATGUY commented Aug 28, 2022

View reviewed changes

IWANABETHATGUY mentioned this pull request Sep 1, 2022

📎 Tracking tasks for implementing Instantiation expressions #3147

Closed

3 tasks

ematipico added A-Parser Area: parser L-JavaScript Langauge: JavaScript labels Sep 2, 2022

ematipico added this to the 0.10.0 milestone Sep 5, 2022

github-actions bot added the S-Stale label Sep 19, 2022

IWANABETHATGUY added 4 commits September 20, 2022 20:54

fix: 🐛 optional chaining

ff129eb

test: 💍 udpate snapshot

f14b4f5

test: 💍 update snapshot

f5b2053

chore: 🤖 update snapshot

5d3a82c

IWANABETHATGUY force-pushed the fix/optional_chaining_new_expr branch from b6ee4c0 to 5d3a82c Compare September 20, 2022 12:56

fix: 🐛 align to ts

1e2636c

IWANABETHATGUY added 2 commits September 20, 2022 21:20

chore: 🤖 lint and format

6177afc

chore: 🤖 disabled invalid code action case

2f90173

IWANABETHATGUY requested a review from leops as a code owner September 20, 2022 13:36

IWANABETHATGUY commented Sep 20, 2022

View reviewed changes

ematipico approved these changes Sep 20, 2022

View reviewed changes

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts.snap Outdated Show resolved Hide resolved

MichaReiser approved these changes Sep 20, 2022

View reviewed changes

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts Outdated Show resolved Hide resolved

crates/rome_js_parser/src/syntax/expr.rs Outdated Show resolved Hide resolved

crates/rome_js_parser/src/syntax/expr.rs Outdated Show resolved Hide resolved

github-actions bot removed the S-Stale label Sep 21, 2022

IWANABETHATGUY added 5 commits September 21, 2022 21:35

fix: 🐛 remove extra assertion_line

6fc2989

chore: 🤖 add extra tracked comment

7c7017e

chore: 🤖 move inline test case

2554732

chore: 🤖 update parser

a306c8f

chore: 🤖 fmt

fb8b5f7

IWANABETHATGUY commented Sep 21, 2022

View reviewed changes

chore: 🤖 update parser test

7278b0b

MichaReiser merged commit c1fd437 into rome:main Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rome_js_parser): Adding syntax error for new A?.b() #3118

fix(rome_js_parser): Adding syntax error for new A?.b() #3118

IWANABETHATGUY commented Aug 27, 2022 •

edited

IWANABETHATGUY Aug 27, 2022

MichaReiser commented Aug 27, 2022 •

edited

IWANABETHATGUY commented Aug 27, 2022

IWANABETHATGUY commented Aug 27, 2022

IWANABETHATGUY commented Aug 27, 2022

github-actions bot commented Aug 27, 2022

IWANABETHATGUY Aug 28, 2022

MichaReiser Aug 30, 2022

MichaReiser Aug 30, 2022

ematipico commented Sep 5, 2022

github-actions bot commented Sep 19, 2022

netlify bot commented Sep 20, 2022 •

edited

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY Sep 20, 2022

IWANABETHATGUY Sep 20, 2022

ematipico Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

IWANABETHATGUY Sep 21, 2022

fix(rome_js_parser): Adding syntax error for new A?.b() #3118

fix(rome_js_parser): Adding syntax error for new A?.b() #3118

Conversation

IWANABETHATGUY commented Aug 27, 2022 • edited

Summary

Test Plan

Choose a reason for hiding this comment

MichaReiser commented Aug 27, 2022 • edited

IWANABETHATGUY commented Aug 27, 2022

IWANABETHATGUY commented Aug 27, 2022

IWANABETHATGUY commented Aug 27, 2022

github-actions bot commented Aug 27, 2022

Parser Benchmark Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico commented Sep 5, 2022

github-actions bot commented Sep 19, 2022

netlify bot commented Sep 20, 2022 • edited

✅ Deploy Preview for docs-rometools ready!

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

IWANABETHATGUY commented Sep 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IWANABETHATGUY commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

Parser Benchmark Results

Choose a reason for hiding this comment

IWANABETHATGUY commented Aug 27, 2022 •

edited

MichaReiser commented Aug 27, 2022 •

edited

netlify bot commented Sep 20, 2022 •

edited