This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Format Arrow Chains #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6499e2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf78502b.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-arrow-chain.tools-8rn.pages.dev |
|
Would you mind updating |
I'll do so once the dependent PR's are merged |
MichaReiser
force-pushed
the
feat/arrow-chain
branch
from
82c5ab2
to
6a61e9f
Compare
MichaReiser
commented
Aug 29, 2022
...formatter/tests/specs/prettier/typescript/compiler/contextualSignatureInstantiation2.ts.snap
Outdated
Show resolved
Hide resolved
MichaReiser
force-pushed
the
feat/arrow-chain
branch
from
6a61e9f
to
e1078d8
Compare
MichaReiser
force-pushed
the
feat/arrow-chain
branch
from
be91c58
to
9418cc9
Compare
MichaReiser
force-pushed
the
feat/arrow-chain
branch
from
9418cc9
to
1b91fee
Compare
ematipico
approved these changes
Aug 30, 2022
This PR adds support for formatting arrow expression chains ``` const x = (a): string => (b) => (c) => (d) => (e) => f; ```
MichaReiser
force-pushed
the
feat/arrow-chain
branch
from
1b91fee
to
908d3d1
Compare
ematipico
approved these changes
Aug 30, 2022
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
ematipico
added a commit
that referenced
this pull request
Sep 5, 2022
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for formatting arrow expression chains
Based on the
IndentIfBreakIR Element #3116Test Plan
Added new snapshot tests for arrow chains
Average compatibility: 84.74 -> 84.94
Compatible lines: 82.81-> 83.08