This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): issue #3175 #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
leops
reviewed
Sep 9, 2022
ematipico
force-pushed
the
fix/issue-3175
branch
from
856aa98
to
6cc1194
Compare
ematipico
force-pushed
the
fix/issue-3175
branch
from
6cc1194
to
71b1937
Compare
ematipico
force-pushed
the
fix/issue-3175
branch
from
71b1937
to
54488e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3175
The issue was caused a particular shape of the
rome.jsonand the old logic was not taken that into consideration. For example, when thejavascript.formattersection was not present in the configuration file and CLI requests to override some default of that part of the configuration.This PR should fix these cases.
Test Plan
I added two test cases