This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_wasm): fix the WASM diagnostic printer #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
approved these changes
Oct 6, 2022
ematipico
added
the
A-Tooling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
DiagnosticPrinterwas broken since #3315 as it was not deserializing diagnostics from JS back into Rust with the correct type (it was usingrome_diagnostics::Diagnosticinstead ofrome_diagnostics::v2::serde::Diagnostic). This should fix the outstanding issue of the Playground failing to print the diagnostics.Test Plan
I've added a new case in the tests of the WASM API in
@rometools/js-apito check the diagnostic printer works correctly