Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

chore: remove preview from VSCode extension #3759

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

ematipico
Copy link
Contributor

Summary

Closes #3701

Test Plan

Merge it and publish a new release (nightly)

@ematipico ematipico requested a review from a team November 16, 2022 09:42
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit c2fe0f6
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6374b074d7a68900076dcf4a

@MichaReiser
Copy link
Contributor

Merge it and publish a new release (nightly)

I would have expected that our nightly release remain previews. Will this be the case after landing your change or not?

@ematipico
Copy link
Contributor Author

Merge it and publish a new release (nightly)

I would have expected that our nightly release remain previews. Will this be the case after landing your change or not?

It won't be the case, but we already specify that preview releases use odd number in the website. We should be be good.

@ematipico ematipico merged commit ded8453 into main Nov 16, 2022
@ematipico ematipico deleted the chore/remove-preview branch November 16, 2022 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Remove "preview" label from VSCode extension
2 participants