Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_syntax,rome_json_syntax): Rename Unknown nodes to Bogus #3881

Merged
merged 1 commit into from Nov 28, 2022

Conversation

MichaReiser
Copy link
Contributor

Summary

This PR renames the Unknown nodes to Bogus.

The main reason is that Unknown may conflict with real syntax. For example, TS defines a unknown type and the node is named TsUnknownType but it isn't an unknown node in the sense of JsUnknownExpression etc.

Renaming Unknown to Bogus solves this problem. I doubt that any language uses Bogus as a real term for their syntax.

@MichaReiser MichaReiser added L-JavaScript Langauge: JavaScript L-JSON Language: JSON I-Easy Implementation: easy task, usually a good fit for new contributors labels Nov 28, 2022
@MichaReiser MichaReiser marked this pull request as draft November 28, 2022 10:18
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 2bfff70
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63849b7f6afa7c000833adb0

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

@MichaReiser MichaReiser marked this pull request as ready for review November 28, 2022 11:29
@MichaReiser MichaReiser merged commit 12ce753 into main Nov 28, 2022
@MichaReiser MichaReiser deleted the refactor/bogus branch November 28, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I-Easy Implementation: easy task, usually a good fit for new contributors L-JavaScript Langauge: JavaScript L-JSON Language: JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants