This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): rename --apply-suggested to --apply-unsafe
#4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: rename `--apply-suggested` to `--apply-unsafe`
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
leops
approved these changes
Dec 21, 2022
|
Nit: It could ease the user migration by continuing to support the old argument (without mentioning it in the help) and printing a warning if it is used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename
--apply-suggestedto--apply-unsafeSummary
Closes #3782
In #3782, some users expressed that the argument's name doesn't sufficiently describe its intent and result. This PR changes the name of
--apply-suggestedto--apply-unsafeTest Plan
I updated the snapshot tests. The current CI should work.
Documentation