This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noSvgWithoutTitle #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
ematipico
approved these changes
Feb 20, 2023
Comment on lines
75
to
76
| match node { | ||
| AnyJsxElement::JsxOpeningElement(_) => { |
There was a problem hiding this comment.
Nit: considering we want to match against only one type, maybe if let AnyJsxElement::JsxOpeningElement(_) = node {} works better
crates/rome_js_analyze/src/analyzers/nursery/no_svg_without_title.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_svg_without_title.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_svg_without_title.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_svg_without_title.rs
Outdated
Show resolved
Hide resolved
feat: check title tag test: add test cases wip feat: update impl to show diagnostics correctly refactor: logic for detecting a valid title test: update snapshot fix: check attribute usage fix: doc test, comment, diagnostics chore: update description and codegen test: simplify texts chore: restore waste change refactor refactor: naming
|
@ematipico Thanks for the review. Could you review this pr again? |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3940
Summary
This pr adds a new rule
noSvgWithoutTitlefor a11y.Below is from description.
Test Plan
cargo test -p rome_js_analyze -- no_svg_without_titleDocumentation