This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): apply formatter to code actions #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
A-CLI
ematipico
force-pushed
the
feat/formatted-code-actions
branch
2 times, most recently
from
0884dbc
to
5799e4f
Compare
ematipico
force-pushed
the
feat/formatted-code-actions
branch
from
5799e4f
to
bb54df8
Compare
ematipico
force-pushed
the
feat/formatted-code-actions
branch
from
bb54df8
to
b0a7927
Compare
ematipico
force-pushed
the
feat/formatted-code-actions
branch
from
b0a7927
to
65b1723
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR, the code emitted by the analyzer actions is now formatted using Rome's internal formatter. After all the analyzer actions have been committed to the current code, the formatting is applied at the end.
If the formatter is disabled, no formatting is applied.
Test Plan
Existing tests should be updated.
Documentation