This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a command to Rome CLI called
rome migrate
.The command intends to migrate Rome's configuration to a new version when breaking changes occur. As for now there aren't any migrations, so the command will always output the same message.
The migration uses the existing analyzer infrastructure of the crate
rome_analyzer
. Migrations are just Rules under the categoryRuleCategories::Action
. Using this infrastructure, we can name the migrations, document them and use their version.I took the opportunity to refactor a bit the internals of the CLI:
diagnostics.rs
filestdin
operations into a specific file/function => this will become useful for doing linting viastdin
Test Plan
For now, I just created few test cases
Changelog
Documentation