Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): add more eslint's tests and refactor for useAltText #4437

Merged
merged 3 commits into from
May 4, 2023

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented May 4, 2023

Summary

I refactored useAltText and fix some true negative diagnostics

Test Plan

I added more eslint's tests.

Changelog

This is a internal refactoring.

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 62ae11a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64535f4989d6100008beb49f
😎 Deploy Preview https://deploy-preview-4437--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47796 47796 0
Failed 1067 1067 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1763 1763 0
Failed 4449 4449 0
Panics 0 0 0
Coverage 28.38% 28.38% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13127 13127 0
Failed 4097 4097 0
Panics 0 0 0
Coverage 76.21% 76.21% 0.00%

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @nissy-dev ! Amazing contributions you're doing!

@ematipico ematipico merged commit ad8dd54 into main May 4, 2023
17 checks passed
@ematipico ematipico deleted the refactor/use-alt-text branch May 4, 2023 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Parser Area: parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants