This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): update noNoninteractiveElementToInteractiveRole and noNoninteractiveTabindex
#4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
unvalley
changed the title
noNoninteractiveElementToInteractiveRole
feat: wip fix: handle input type hidden and refactor
unvalley
changed the title
noNoninteractiveElementToInteractiveRolenoNoninteractiveElementToInteractiveRole and noNoninteractiveTabindex
unvalley
commented
May 5, 2023
| @@ -324,7 +324,7 @@ define_role! { | |||
| /// https://www.w3.org/TR/wai-aria-1.1/#link | |||
| LinkRole { | |||
| PROPS: [("aria-expanded", false)], | |||
| ROLES: ["command"], | |||
| ROLES: ["command", "widget"], | |||
There was a problem hiding this comment.
The changes to ROLES in this diff is based on the following link.
https://w3c.github.io/aria/#widget_roles
In order to pass the jsx-a11y test case, it was necessary to refer to this Draft stage document.
ematipico
approved these changes
May 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3816
noNoninteractiveElementToInteractiveRoleis already implemented partiallynoNoninteractiveElementToInteractiveRoleandnoNoninteractiveTabindexrules in identifying non-interactive elements and displaying the corresponding diagnostics.noNoninteractiveTabindexrule test case has not changed.Test Plan
cargo test -p rome_js_analyze -- no_noninteractive_element_to_interactive_role<hr>from invalid because it can be a widget role<Article role="button" />) because we really should not be able to know if it is not interactive. (I don't know why jsx-a11y warn about it. I may have missed something.)Changelog
Documentation
[ ] The PR requires documentation[ ] I will create a new PR to update the documentation