This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_service): correctly send file source to workspace #4466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4458
The previous PR was send the default
SourceType
, which wasn't the correct way.This PR fixes the issue by doing the following:
FileSource
, which will be used to share behaviour for those file sources that need to be sent across thread boundaries;AnyFileSource
, a language-agnostic data structure that will be used when using theWorkspace
. This type has a method calledtry_from
, which will attempt to recreate the file source based on the path of the fileI renamed
SouceType
toJsFileSource
.Test Plan
Current tests should pass. I created a new test case to fix the issue
Changelog
(I will create changelog line in
next-release
branch, to avoid too many conflicts)Documentation