Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): Fix false positive diagnostics that useHookAtTopLevel caused to as or satisfies expressions. #4467

Merged
merged 2 commits into from
May 13, 2023
Merged

fix(rome_js_analyze): Fix false positive diagnostics that useHookAtTopLevel caused to as or satisfies expressions. #4467

merged 2 commits into from
May 13, 2023

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented May 12, 2023 •
edited
Loading

Summary

Fix #4463

Test Plan

I add some snapshot tests

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented May 12, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 62e478c
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/645e6d24c0273e00079709f8

@github-actions github-actions bot added the A-Linter Area: linter label May 12, 2023
ematipico
ematipico approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nissy-dev nissy-dev merged commit 5fa5dd1 into main May 13, 2023
16 checks passed
@nissy-dev nissy-dev deleted the fix/useHooksAtTopLevel-false-positive branch May 13, 2023 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 nursery/useHooksAtTopLevel false positive
2 participants
@nissy-dev @ematipico