Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

chore: Resolve set-output deprecations #4507

Merged
merged 1 commit into from
May 19, 2023

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented May 17, 2023

Summary

CI gives this warning:

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

Migration guide is located here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 309f3c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64666a499c9e87000862af2f
😎 Deploy Preview https://deploy-preview-4507--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! Just a small comment left

.github/workflows/bench_analyzer.yml Outdated Show resolved Hide resolved
@Boshen
Copy link
Contributor

Boshen commented May 18, 2023

The code is pretty old, we can just pipe it into a file instead https://github.com/Boshen/oxc/blob/9678832f2b1124c118d33ab48ad984c9906da9a0/.github/workflows/benchmark.yml#L121

CI gives this warning:
```
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.
```

Migration guide is located here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@nikeee nikeee force-pushed the enhancement/migrate-set-output branch from cd0a866 to 309f3c7 Compare May 18, 2023 18:11
@ematipico
Copy link
Contributor

!bench_parser

@github-actions
Copy link

Parser Benchmark Results

group                                          main                                   pr
-----                                          ----                                   --
parser/big5-added.json/cached                  1.01    158.5±1.84µs   106.6 MB/sec    1.00    157.2±3.31µs   107.5 MB/sec
parser/big5-added.json/uncached                1.00    188.5±0.11µs    89.6 MB/sec    1.00    187.8±0.08µs    89.9 MB/sec
parser/canada.json/cached                      1.06    105.4±4.99ms    20.4 MB/sec    1.00     99.3±3.59ms    21.6 MB/sec
parser/canada.json/uncached                    1.00     99.6±3.68ms    21.6 MB/sec    1.00     99.6±2.61ms    21.6 MB/sec
parser/checker.ts/cached                       1.02    125.6±2.94ms    20.7 MB/sec    1.00    123.5±2.01ms    21.1 MB/sec
parser/checker.ts/uncached                     1.00    127.6±1.59ms    20.4 MB/sec    1.01    129.3±2.53ms    20.1 MB/sec
parser/compiler.js/cached                      1.00     71.5±2.50ms    14.7 MB/sec    1.02     72.9±2.20ms    14.4 MB/sec
parser/compiler.js/uncached                    1.00     72.6±1.43ms    14.4 MB/sec    1.02     74.1±1.77ms    14.2 MB/sec
parser/d3.min.js/cached                        1.00     42.8±1.13ms     6.1 MB/sec    1.01     43.2±1.22ms     6.1 MB/sec
parser/d3.min.js/uncached                      1.03     44.9±1.24ms     5.8 MB/sec    1.00     43.4±0.55ms     6.0 MB/sec
parser/db.json/cached                          1.01      4.4±0.05ms    41.5 MB/sec    1.00      4.4±0.02ms    41.7 MB/sec
parser/db.json/uncached                        1.00      4.9±0.02ms    37.5 MB/sec    1.00      4.9±0.02ms    37.5 MB/sec
parser/dojo.js/cached                          1.01      3.3±0.01ms    20.6 MB/sec    1.00      3.3±0.01ms    20.7 MB/sec
parser/dojo.js/uncached                        1.00      3.7±0.00ms    18.6 MB/sec    1.00      3.7±0.01ms    18.7 MB/sec
parser/eucjp.json/cached                       1.00    257.2±1.37µs   152.2 MB/sec    1.00    257.4±1.75µs   152.1 MB/sec
parser/eucjp.json/uncached                     1.00    296.0±0.30µs   132.3 MB/sec    1.00    295.8±0.27µs   132.4 MB/sec
parser/ios.d.ts/cached                         1.01    116.3±2.19ms    16.0 MB/sec    1.00    115.4±1.48ms    16.2 MB/sec
parser/ios.d.ts/uncached                       1.00    111.9±1.27ms    16.7 MB/sec    1.00    112.0±1.56ms    16.7 MB/sec
parser/jquery.min.js/cached                    1.00     11.1±0.06ms     7.4 MB/sec    1.00     11.1±0.07ms     7.4 MB/sec
parser/jquery.min.js/uncached                  1.00     11.5±0.06ms     7.2 MB/sec    1.00     11.5±0.05ms     7.2 MB/sec
parser/math.js/cached                          1.02     88.5±1.72ms     7.3 MB/sec    1.00     86.5±1.70ms     7.5 MB/sec
parser/math.js/uncached                        1.00     89.5±1.49ms     7.2 MB/sec    1.00     89.7±1.91ms     7.2 MB/sec
parser/package-lock.json/cached                1.00  1801.7±31.30µs    76.5 MB/sec    1.00   1803.0±9.13µs    76.5 MB/sec
parser/package-lock.json/uncached              1.00   1955.8±5.34µs    70.5 MB/sec    1.01  1975.8±14.02µs    69.8 MB/sec
parser/parser.ts/cached                        1.00      2.4±0.00ms    20.2 MB/sec    1.00      2.4±0.00ms    20.3 MB/sec
parser/parser.ts/uncached                      1.00      2.7±0.00ms    18.4 MB/sec    1.00      2.7±0.01ms    18.4 MB/sec
parser/pixi.min.js/cached                      1.03     55.0±2.22ms     8.0 MB/sec    1.00     53.4±1.62ms     8.2 MB/sec
parser/pixi.min.js/uncached                    1.02     56.3±1.57ms     7.8 MB/sec    1.00     54.9±1.15ms     8.0 MB/sec
parser/react-dom.production.min.js/cached      1.00     14.9±0.20ms     7.7 MB/sec    1.01     15.1±0.34ms     7.6 MB/sec
parser/react-dom.production.min.js/uncached    1.00     15.7±0.13ms     7.3 MB/sec    1.01     15.8±0.23ms     7.3 MB/sec
parser/react.production.min.js/cached          1.00    708.8±2.48µs     8.7 MB/sec    1.00    705.8±2.84µs     8.7 MB/sec
parser/react.production.min.js/uncached        1.00    790.2±1.11µs     7.8 MB/sec    1.00    790.6±1.08µs     7.8 MB/sec
parser/router.ts/cached                        1.00    924.2±4.62µs    34.5 MB/sec    1.01    928.9±5.06µs    34.4 MB/sec
parser/router.ts/uncached                      1.00   1079.0±1.90µs    29.6 MB/sec    1.00   1083.9±2.74µs    29.4 MB/sec
parser/tex-chtml-full.js/cached                1.00    122.1±1.79ms     7.5 MB/sec    1.01    123.0±2.10ms     7.4 MB/sec
parser/tex-chtml-full.js/uncached              1.03    125.2±1.57ms     7.3 MB/sec    1.00    122.1±1.45ms     7.5 MB/sec
parser/three.min.js/cached                     1.01     61.7±2.20ms     9.5 MB/sec    1.00     61.3±1.84ms     9.6 MB/sec
parser/three.min.js/uncached                   1.00     61.4±1.85ms     9.6 MB/sec    1.03     63.5±1.80ms     9.3 MB/sec
parser/typescript.js/cached                    1.00    507.9±4.45ms    18.7 MB/sec    1.00    506.3±4.60ms    18.8 MB/sec
parser/typescript.js/uncached                  1.00    513.0±3.79ms    18.5 MB/sec    1.00    513.8±5.12ms    18.5 MB/sec
parser/vue.global.prod.js/cached               1.03     19.0±0.50ms     6.3 MB/sec    1.00     18.4±0.14ms     6.6 MB/sec
parser/vue.global.prod.js/uncached             1.03     19.5±0.35ms     6.2 MB/sec    1.00     19.0±0.08ms     6.4 MB/sec

@ematipico ematipico merged commit 6c8b37f into rome:main May 19, 2023
5 checks passed
@nikeee nikeee deleted the enhancement/migrate-set-output branch May 19, 2023 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants