This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat: add support for .jsonc files
#4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
github-actions
bot
added
A-CLI
ematipico
force-pushed
the
feat/support-jsonc-files
branch
from
2e2d6f3
to
86a5460
Compare
github-actions
bot
added
A-Linter
arendjr
reviewed
Jul 28, 2023
ematipico
force-pushed
the
feat/support-jsonc-files
branch
2 times, most recently
from
af3128e
to
5788d49
Compare
ematipico
force-pushed
the
feat/support-jsonc-files
branch
from
5788d49
to
ccdcc61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for parsing
.jsoncfiles.Additionally, I added some "known files" that should be parse as
jsoncfiles. The list of files was copied from the VSCode repository: https://github.com/microsoft/vscode/blob/67d7cbc82247f6695854ebe70a66d275ebd5f479/extensions/json/package.json#L47-L69Test Plan
I added new test cases