This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix: image urls are broken in meta tags #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image meta tags urls in the rome tools website are broken and link to https://rome.toolsimg/social-logo.png instead of https://rome.tools/img/social-logo.png ``` <meta content="https://rome.toolsimg/social-logo.png" property="og:image"> ``` The site url in the astro.config.ts is set to https://rome.tools, so a slash needs to be added for it to work properly ``` site: "https://rome.tools", ```
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The image meta tags urls in the rome tools website are broken and link to https://rome.toolsimg/social-logo.png instead of https://rome.tools/img/social-logo.png
The site url in the astro.config.ts is set to https://rome.tools, so a slash needs to be added for it to work properly
Test Plan
The fix is to add a slash to a broken URL, I made sure that the updated url works and navigates to the social-logo.png image.