Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettier to format docs #67

Merged
merged 3 commits into from
Apr 26, 2023
Merged

use prettier to format docs #67

merged 3 commits into from
Apr 26, 2023

Conversation

bingtsingw
Copy link
Sponsor Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for orchid-orm ready!

Name Link
🔨 Latest commit 51506db
🔍 Latest deploy log https://app.netlify.com/sites/orchid-orm/deploys/6448eca7d58127000895ca2e
😎 Deploy Preview https://deploy-preview-67--orchid-orm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@romeerez
Copy link
Owner

romeerez commented Apr 26, 2023

Vitepress has a weird structure, so .vitepress/theme and .vitepress/config should be in git and to be formatted, but not the .vitepress/cache and also it writes .vitepress/dist when building.

Could you change .prettierignore to only ignore .vitepress/cache and .vitepress/dist?

Also, by the way, could you remove the .vitepress/cache to .gitignore and remove it from git entirely, it has gotten here accidentally.

Adding a second commit in this PR is fine.

@romeerez
Copy link
Owner

And after adding .vitepress/cache to gitignore, I guess prettier will ignore it by looking into gitignore and no need for prettierignore. Not 100% sure

@bingtsingw
Copy link
Sponsor Contributor Author

And after adding .vitepress/cache to gitignore, I guess prettier will ignore it by looking into gitignore and no need for prettierignore. Not 100% sure

Prettier do not support reading .gitignore by default see this.

@romeerez romeerez merged commit ed74517 into romeerez:main Apr 26, 2023
6 checks passed
@romeerez
Copy link
Owner

Thank you, glad to see -11k and formatting is for better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants