Resets close_selector if needed on dynamic modals

romellem · Aug 23, 2020 · 52c4630 · 52c4630
1 parent c9e3d98
commit 52c4630
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/docs/examples.iife.js b/docs/examples.iife.js
@@ -289,8 +289,12 @@
       if (modal_is_dynamic) {
         modal_node = createModalNode(trigger_node, event); // Always check for the default close selector if none was specified for a dynamic modal
 
-        if (no_close_selector_specified && modal_node.querySelector(default_close_selector)) {
-          close_selector = default_close_selector;
+        if (no_close_selector_specified) {
+          if (modal_node.querySelector(default_close_selector)) {
+            close_selector = default_close_selector;
+          } else {
+            close_selector = undefined;
+          }
         }
       }
 

diff --git a/src/yamodal.js b/src/yamodal.js
@@ -120,8 +120,12 @@ const initializeModalListener = ({
 			modal_node = createModalNode(trigger_node, event);
 
 			// Always check for the default close selector if none was specified for a dynamic modal
-			if (no_close_selector_specified && modal_node.querySelector(default_close_selector)) {
-				close_selector = default_close_selector;
+			if (no_close_selector_specified) {
+				if (modal_node.querySelector(default_close_selector)) {
+					close_selector = default_close_selector;
+				} else {
+					close_selector = undefined;
+				}
 			}
 		}