Skip to content

Commit

Permalink
BREAKING - Replaces custom event name
Browse files Browse the repository at this point in the history
I got this namespace wrong; typically the namespace is listed after the
regular event. Of course this doesn't really matter, but seems like
something to change before the major version.

Before I can publish this, this will request a major version change,
which isn't a big deal.
  • Loading branch information
romellem committed Oct 3, 2020
1 parent c278dcc commit d238175
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/examples.iife.js
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,11 @@
},

open: function open() {
var event = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : createEmptyCustomEvent('yamodal.open');
var event = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : createEmptyCustomEvent('open.yamodal');
return onTriggerOpen(event);
},
close: function close() {
var event = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : createEmptyCustomEvent('yamodal.close');
var event = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : createEmptyCustomEvent('close.yamodal');
return onTriggerClose(event);
},
isOpen: function isOpen() {
Expand Down
4 changes: 2 additions & 2 deletions src/yamodal.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ const initializeModalListener = ({
get modal_node() {
return modal_node;
},
open(event = createEmptyCustomEvent('yamodal.open')) {
open(event = createEmptyCustomEvent('open.yamodal')) {
return onTriggerOpen(event);
},
close(event = createEmptyCustomEvent('yamodal.close')) {
close(event = createEmptyCustomEvent('close.yamodal')) {
return onTriggerClose(event);
},
isOpen() {
Expand Down

0 comments on commit d238175

Please sign in to comment.