[fetcher] allowDoctype not used for cache

[mishako]

Issue by arosenheinrich
Sunday Aug 30, 2015 at 10:47 GMT
Originally opened as https://github.com/rometools/rome-fetcher/issues/19

---

I encountered the following problem using release 1.5.1: when trying to fetch a feed using Doctype I can not fetch it out of the box anymore because this is restricted by default. Setting system property rome.allowDoctype:true should enable it again. But this only seems to work when using a fetcher without cache:

    URL url = new URL("http://www.immobilienmanager.de/?id=640&type=100");
    //FeedFetcherCache feedInfoCache = HashMapFeedInfoCache.getInstance();
    //FeedFetcher feedFetcher = new HttpURLFeedFetcher(feedInfoCache);
    FeedFetcher feedFetcher = new HttpURLFeedFetcher();
    SyndFeed feed = feedFetcher.retrieveFeed(url);
    System.out.println(feed.getEntries().size());

When I use feedFetcher with feedInfoCache in my example it aint working. Seems like caches do not evaluate the rome.allowDoctype property.

[PatrickGotthard]

Hi @arosenheinrich,

you shouldn't be able to fetch feeds with a doctype declaration regardless whether you use a cache or not. You were only able to allow doctype declarations directly on a SyndFeedInput instance. The (system) property you mentioned above doesn't exist? In the next ROME release you should be able to allow doctype declarations using rome-fetcher.

Regards,
Patrick