Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying Dirty Fields #10

Closed
wants to merge 2 commits into from
Closed

Copying Dirty Fields #10

wants to merge 2 commits into from

Commits on Mar 14, 2014

  1. PEP8-ness

    @Xowap
    Xowap committed Mar 14, 2014
    Copy the full SHA
    6b4dcee View commit details
    Browse the repository at this point in the history

  2. Insert copies in _original_state, instead of references 

    Otherwise, the behaviour becomes bogus when dealing with objects more complex
than simple types, like GEOS geometries.

Won't the copy take more memory? Well, very few, because it is a shallow copy,
and thus all objects referenced by the root object stay the same.

Shouldn't this be optional? For all the use cases that worked currently, it
doesn't change anything (a copy of a bool or of a string will use the same
amount of memory than before), and for other cases it is the only way to solve a
critical bug. So there is no point making this optional.
    @Xowap
    Xowap committed Mar 14, 2014
    Copy the full SHA
    efd0286 View commit details
    Browse the repository at this point in the history