The 1000 mulitplier was converting to seconds #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate that the number is ops/ms not ops/s and another small fix
|
What about releasing 0.4.2? I think we should switch to 0.5.0 for the Kryo-4.0.0 upgrade as the serialization is incompatible with previous releases. There is a backward compatibility switch (for handling the generics in the FiledsSerializer). Do you think we should also add a flag so that we can upgrade to Kryo-4.0.0 but keep backward compatibility? I am not sure this would be enough as there are also new serializers for java8 optionals - they are used also by the new scala compiler backed (by default in 2.12, with a switch in 2.11). I think a cleaner path forward is to declare backward incompatibility due to Kryo-4.0 and handling of the new Java 8 classes. |
- don't include a mutable.HashMap value member in the tested maps: it's a constant factor tested separately - add tests for Vector[Int] and Array[Int]
that the Unsafe serialization can create bugger payloads but is faster in some cases
compose the pipeline up to a function only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate that the number is ops/ms not ops/s and another small fix.