Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any benchmark update with core.fsmonitor=true since git 2.37.0? #370

Closed
linrongbin16 opened this issue Jan 30, 2023 · 4 comments
Closed

Comments

@linrongbin16
Copy link

Hi, first thanks for great work in this project.

In git 2.37.0, there is a feature file system monitor, could improve big performance. Would you please update benchmark with option core.fsmonitor=true and core.untrackedcache=true?

See: https://github.blog/2022-06-29-improve-git-monorepo-performance-with-a-file-system-monitor/

@linrongbin16 linrongbin16 changed the title Any benchmark update with git 2.37.0? Any benchmark update with core.fsmonitor=true since git 2.37.0? Jan 30, 2023
@romkatv
Copy link
Owner

romkatv commented Jan 30, 2023

That's cool! Thanks for letting me know about this feature.

I considered using inotify but decided against it because the default max_user_watches limit is much too low to be useful for gitstatusd and I cannot ask or expect users to change their system settings. There are more details in the discussion of this commit.

Do you perchance know how git solves this problem? What does it do if the repo has more than max_user_watches directories?

@linrongbin16
Copy link
Author

no idea, just read this blog

@romkatv
Copy link
Owner

romkatv commented Jan 30, 2023

I added an explicit note to the docs saying core.fsmonitor was disable in git benchmarks. I don't intend to do anything else related to core.fsmonitor in the near future because nothing will depend on the outcome of benchmarks if I were to re-run them with core.fsmonitor set to true. Few users have git 2.37.0+ and even fewer explicitly enable core.fsmonitor, which means I cannot replace gitstatusd powerlevel10k with plain git.

That said, if you are using gitstatus explicitly (not via powerlevel10k) for its performance benefits over git, consider switching to plain git if it's fast enough with core.fsmonitor enabled.

@bluz71
Copy link

bluz71 commented May 2, 2023

I carried out some performance tested and documented it over at issue #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants