fix: allow filesystem cache to be cleared when directory does not exist

romm · Jul 10, 2023 · 7824083 · 7824083
1 parent 873961e
commit 7824083
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Cache/Compiled/CompiledPhpFileCache.php b/src/Cache/Compiled/CompiledPhpFileCache.php
@@ -113,6 +113,10 @@ public function delete($key): bool
 
     public function clear(): bool
     {
+        if (! is_dir($this->cacheDir)) {
+            return true;
+        }
+
         $success = true;
 
         /** @var FilesystemIterator $file */

diff --git a/tests/Unit/Cache/Compiled/CompiledPhpFileCacheTest.php b/tests/Unit/Cache/Compiled/CompiledPhpFileCacheTest.php
@@ -17,6 +17,7 @@
 use RuntimeException;
 
 use function iterator_to_array;
+use function rmdir;
 
 final class CompiledPhpFileCacheTest extends TestCase
 {
@@ -113,6 +114,13 @@ public function test_clear_cannot_delete_cache_file_returns_false(): void
         self::assertFalse($this->cache->clear());
     }
 
+    public function test_clear_caches_when_cache_directory_does_not_exists_returns_true(): void
+    {
+        rmdir($this->files->url());
+
+        self::assertTrue($this->cache->clear());
+    }
+
     public function test_set_multiple_values_sets_values(): void
     {
         self::assertTrue($this->cache->setMultiple([