Skip to content

Commit

Permalink
misc: Remove mentions to unneeded Poetry mention
Browse files Browse the repository at this point in the history
Poetry 1.8.0 already includes support for `package-mode = false`, so
there's no need to install a Poetry fork anymore.
  • Loading branch information
adamantike committed Jun 23, 2024
1 parent 2f1daae commit b6e5763
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
16 changes: 6 additions & 10 deletions DEVELOPER_SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,16 @@ You'll need poetry installed

https://python-poetry.org/docs/#installing-with-the-official-installer

**_WARNING:_** Until poetry 1.8.0 version is released, poetry needs to be installed with the new non-package-mode feature branch:

```sh
pipx install --suffix _npm git+https://github.com/radoering/poetry.git@non-package-mode
pipx install poetry
```

More info: https://github.com/python-poetry/poetry/pull/8650

Then create the virtual environment

```sh
# Fix disable parallel installation stuck: $> poetry_npm config experimental.new-installer false
# Fix disable parallel installation stuck: $> poetry config experimental.new-installer false
# Fix Loading macOS/linux stuck: $> export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring
poetry_npm install --sync
poetry install --sync
```

### - Spin up mariadb in docker
Expand All @@ -62,14 +58,14 @@ docker-compose up -d

```sh
cd backend
poetry_npm run python3 main.py
poetry run python3 main.py
```

### - Start a worker

```sh
cd backend
poetry_npm run python3 worker.py
poetry run python3 worker.py
```

## Setting up the frontend
Expand Down Expand Up @@ -130,5 +126,5 @@ docker exec -i mariadb mariadb -u root -p<root password> < backend/romm_test/set
```sh
cd backend
# path or test file can be passed as argument to test only a subset
poetry_npm run pytest [path/file]
poetry run pytest [path/file]
```
2 changes: 1 addition & 1 deletion backend/utils/generate_supported_platforms.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# poetry_npm run python3 -m utils.generate_supported_platforms
# poetry run python3 -m utils.generate_supported_platforms
from typing import TypedDict

from handler.metadata.igdb_handler import IGDB_PLATFORM_LIST
Expand Down

0 comments on commit b6e5763

Please sign in to comment.