Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enhanced tagging (region/language/custom) #473

Closed
XargonWan opened this issue Nov 24, 2023 · 5 comments
Closed

[Feature] Enhanced tagging (region/language/custom) #473

XargonWan opened this issue Nov 24, 2023 · 5 comments
Assignees
Labels
feature New feature or request

Comments

@XargonWan
Copy link
Contributor

I am theorizing a better way to manage the tags.

Region and Languages

Basically now the tags are took in a non standard way, usually the dumps come with (rev a)(eu)(it, en, de, fr, spa) for example.
Now RomM can only recognize the region via specific tags like (reg-USA), however this is non-standard.

A (possibly) comprehensive list of languages and regions.

Languages

E/EN/ENG
I/IT/ITA
J/JP*
S/SP/SPA
G/GER
F/FR/FRA
C/CH/CHN*

Regions

E/EU
J/JP*
C/CH/CHN*
H/HK
G/W/GLOBAL/WORLD
ASIA
U/US/USA
B/BRA
AU
UK
  • * means that is both a language and a region

FYI: avoid "JAP" as it's racist.

Emoji

Then it would be cool to give the user the option to show the region flags, options: eu, 🇪🇺, 🇪🇺 eu

Custom tags

Moreover it would be useful that if a tag is not recognized it will be treated as a custom tag, for example: Jazz Jackrabbit Holiday Hare 1995 (hello).dosz would be tagged as hello.

@XargonWan XargonWan added the feature New feature or request label Nov 24, 2023
@gantoine
Copy link
Member

gantoine commented Dec 3, 2023

It already supports extracting text wrapped in () or [] as tags, check the code in /backend/utils/init.py. Let me know if we're missing any regions from the list.

We don't currently scan for the language, but the code is there to start doing so. I will implement the change to use emojis instead of text for regions!

@gantoine
Copy link
Member

gantoine commented Dec 3, 2023

BTW some of the regions you listed are incorrect, for instance H is Holland, C is Canada, etc.

@crispybegs
Copy link

crispybegs commented Jan 26, 2024

is thre any way of removing the flags from the covers? they often cover the whole artwork and it's not very elegant

Screenshot 2024-01-26 at 20 28 22

@gantoine
Copy link
Member

Not at the moment, but you can use the large format of the covers which will display more art.

@crispybegs
Copy link

Not at the moment, but you can use the large format of the covers which will display more art.

ah ok, that's a shame. would be nice to have a simple toggle on/off to remove them, especially when viewing on a small laptop screen or phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants