Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-473] Enhanced region and language tagging #478

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[ROMM-473] Enhanced region and language tagging #478

merged 3 commits into from
Dec 5, 2023

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Dec 4, 2023

Adds support for filenames with multiple language and region tags, like Super Metroid (Japan, USA) (En,Ja).zip. Also uses emojis on the client to display region and language codes.

Closes #473

Screenshots
Screenshot 2023-12-03 at 11 27 06 AM
Screenshot 2023-12-03 at 11 27 11 AM

Copy link

github-actions bot commented Dec 4, 2023

Test Results

69 tests   69 ✔️  17s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 4c2f1d4.

♻️ This comment has been updated with latest results.

@gantoine gantoine changed the title Romm 473 [ROMM-473] Enhanced region and language tagging Dec 4, 2023
@gantoine gantoine marked this pull request as ready for review December 4, 2023 03:55
@gantoine gantoine requested a review from zurdi15 December 4, 2023 03:55
@zurdi15 zurdi15 merged commit 7037151 into master Dec 5, 2023
5 checks passed
@zurdi15 zurdi15 deleted the romm-473 branch December 5, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants