Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort roms by size + scan fixes #424

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix sort roms by size + scan fixes #424

merged 2 commits into from
Oct 31, 2023

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Oct 31, 2023 •
edited
Loading

  • Send new property file_size_bytes to client
  • Computed property based on file_size * file_size_unit
  • Catch FNF errors on second read of index files
Before After
Screenshot 2023-10-31 at 11 12 25 AM Screenshot 2023-10-31 at 11 07 19 AM

Fixes #423

@gantoine gantoine requested a review from zurdi15 October 31, 2023 15:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Test Results

69 tests  ±0   69 ✔️ ±0   23s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 25ebd83. ± Comparison against base commit fa1cdf9.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 merged commit 0b28ba9 into master Oct 31, 2023
5 checks passed
@zurdi15 zurdi15 deleted the romm-423 branch October 31, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurdi15 zurdi15 zurdi15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantoine @zurdi15