Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store fixtures in redis with indexes #763

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Store fixtures in redis with indexes #763

merged 12 commits into from
Mar 27, 2024

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Mar 26, 2024

This PR starts storing the in-code and network-fetched fixtures in Redis with hashed keys for quick access. The benefits of this change are:

  • One-time loading of static fixtures into cache (faster restarts)
  • No need to read fixtures into memory on each scan
  • Fixtures persist between container removals
  • Nightly background task pulls fresh json and updates fixtures
  • Can run the container as non-root user

Also changed:

  • Store MAME fixture as json file
  • Mark /romm/config as a required volume (even empty)
  • Update emulatorjs to 4.0.12
  • Fix crash when scanning new platforms only
  • Remove the task that updates the MAME fixture
  • Add fakeredis to initialize a client for testing
  • Added icons for turbografx-16

Copy link

github-actions bot commented Mar 26, 2024

Test Results

73 tests  ±0   73 ✅ ±0   22s ⏱️ +2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a81b14d. ± Comparison against base commit 1f09eb4.

♻️ This comment has been updated with latest results.

@gantoine gantoine marked this pull request as ready for review March 27, 2024 02:43
@gantoine gantoine requested a review from zurdi15 March 27, 2024 02:50
@gantoine gantoine merged commit ab71532 into master Mar 27, 2024
5 checks passed
@gantoine gantoine deleted the fixtures-in-redis branch March 27, 2024 13:28
@zurdi15 zurdi15 mentioned this pull request Apr 2, 2024
@zurdi15 zurdi15 mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants