Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfixes for Mobygames API #788

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Hotfixes for Mobygames API #788

merged 9 commits into from
Apr 5, 2024

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Apr 3, 2024 •
edited
Loading

  • Change instances of IGDB copy to metadata providers
  • Check is just is running (started) before trying to cancel
  • Fix extracting cover url for mobygames
  • Add moby support for famicom/sfam
  • Manual search defaults to game name, then filename with no extension
  • Add env variable to disable auth on download endpoints (and webrcade feed)
  • Add script to generate supported platforms wiki page
  • Add endpoint for Switch Tinfoil

@gantoine gantoine requested a review from zurdi15 April 3, 2024 14:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Test Results

73 tests   73 ✅  22s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit c5dffaa.

♻️ This comment has been updated with latest results.

zurdi15
zurdi15 previously approved these changes Apr 3, 2024
View reviewed changes
@zurdi15 zurdi15 dismissed their stale review April 3, 2024 19:18

missclick

@gantoine gantoine marked this pull request as ready for review April 4, 2024 19:02
@gantoine gantoine requested a review from zurdi15 April 4, 2024 19:38
@zurdi15 zurdi15 merged commit ad53325 into master Apr 5, 2024
5 checks passed
@zurdi15 zurdi15 deleted the hotfixes-mobygames-api branch April 5, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurdi15 zurdi15 zurdi15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantoine @zurdi15