Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a button to copy download link #810

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Added a button to copy download link #810

merged 5 commits into from
Apr 17, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Apr 12, 2024 •
edited
Loading

  • Added a copy download link button. Also works with the selected files in multi-part games

image

@zurdi15 zurdi15 added the feature New feature or request label Apr 12, 2024
@zurdi15 zurdi15 requested a review from gantoine April 12, 2024 07:43
@zurdi15 zurdi15 self-assigned this Apr 12, 2024
gantoine
gantoine requested changes Apr 13, 2024
View reviewed changes
frontend/src/services/api/rom.ts Outdated Show resolved Hide resolved
frontend/src/components/Details/ActionBar.vue Show resolved Hide resolved
@gantoine
Copy link
Member

Also you should use mdi-content-copy for the icon, share icon has a specific meaning as UX

@zurdi15 zurdi15 requested a review from gantoine April 16, 2024 21:48
@zurdi15 zurdi15 merged commit fdac52a into master Apr 17, 2024
3 checks passed
@zurdi15 zurdi15 deleted the feature/copy_download_link branch April 17, 2024 13:13
@zurdi15 zurdi15 mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees

@zurdi15 zurdi15

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zurdi15 @gantoine