Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale call to update_mame_xml_task in backend run_tasks, since the mame xml update task doesn't exist #836

Closed
wants to merge 1 commit into from

Conversation

cmsj
Copy link

@cmsj cmsj commented May 3, 2024

Description

It's currently not possible to use the Run All button in Settings -> Control Panel because it's trying to run a task to fetch mame xml, which isn't a task defined anywhere in the codebase.

Related Issues

List any related issues that are addressed or fixed by this pull request.

Checklist

Please check all that apply.

  • I've tested the changes locally
  • I've updated the wiki accordingly
  • I've have updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes
  • All existing tests are passing

Additional Notes

Add any additional information or context about the pull request here.

@gantoine gantoine changed the base branch from release to master May 3, 2024 14:24
@gantoine gantoine changed the base branch from master to release May 3, 2024 14:25
@gantoine
Copy link
Member

gantoine commented May 3, 2024

Nice catch, but you could you re-open this PR after branching from the master branch? This is currently set to merge into release, but we work against master.

@gantoine gantoine closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants